PHOENIX-6590 Handle rollbacks in phoenix spark connector and add way to control batch wise or task wise transactions(Rajeshbabu) #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oenix connections created in workers(Rajeshbabu)
Contributor
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
💔 -1 overall
This message was automatically generated. |
joshelser
approved these changes
Nov 15, 2021
Member
joshelser
left a comment
joshelser
left a comment
There was a problem hiding this comment.
Two nit-picky changes. LGTM otherwise.
| if (tenantId != null) { | ||
| overridingProps.put(PhoenixRuntime.TENANT_ID_ATTRIB, tenantId); | ||
| } | ||
| //overridingProps.setProperty("phoenix.transactions.enabled", "true"); |
Member
There was a problem hiding this comment.
nit, remove
Suggested change
| //overridingProps.setProperty("phoenix.transactions.enabled", "true"); |
phoenix-spark-base/src/it/scala/org/apache/phoenix/spark/PhoenixSparkIT.scala
Outdated
Show resolved
Hide resolved
stoty
approved these changes
Nov 23, 2021
Contributor
stoty
left a comment
stoty
left a comment
There was a problem hiding this comment.
+1 LGTM, but please fix the comment typo mentioned by Josh, and add some comments te document the new behaviour to the batch size parameter.
Contributor
|
💔 -1 overall
This message was automatically generated. |
chrajeshbabu
changed the title
chrajeshbabu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.