Skip to content

PHOENIX-6296 Synchronize @Parameters, @BeforeClass and @AfterClass me…#1056

Closed
stoty wants to merge 1 commit intoapache:4.xfrom
stoty:PHOENIX-6296-4.x
Closed

PHOENIX-6296 Synchronize @Parameters, @BeforeClass and @AfterClass me…#1056
stoty wants to merge 1 commit intoapache:4.xfrom
stoty:PHOENIX-6296-4.x

Conversation

@stoty
Copy link
Copy Markdown
Contributor

@stoty stoty commented Jan 4, 2021

…thods take 2

Copy link
Copy Markdown
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding), pending QA

Copy link
Copy Markdown
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stoty stoty closed this Jan 4, 2021
@stoty stoty deleted the PHOENIX-6296-4.x branch July 29, 2021 14:01
haridsv pushed a commit to haridsv/phoenix that referenced this pull request Jun 25, 2024
…che#1056)

* throw exception if row counts do not match

* add null check

* test fix

* new pherf arg for signoff test

* add comment

* edit comment

Co-authored-by: Palash Chauhan <p.chauhan@pchauha-ltm8owy.internal.salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants