Skip to content

PHOENIX-6476 Index tool when verifying from index to data doesn't cor…#1248

Merged
swaroopak merged 1 commit intoapache:masterfrom
tkhurana:PHOENIX-6476-master
Jun 16, 2021
Merged

PHOENIX-6476 Index tool when verifying from index to data doesn't cor…#1248
swaroopak merged 1 commit intoapache:masterfrom
tkhurana:PHOENIX-6476-master

Conversation

@tkhurana
Copy link
Copy Markdown
Contributor

…rectly split page into tasks (#1240)

  • PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks

  • Fix failing tests, add comments

  • Break early when the matching set is found

…rectly split page into tasks (apache#1240)

* PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks

* Fix failing tests, add comments

* Break early when the matching set is found
@tkhurana
Copy link
Copy Markdown
Contributor Author

@swaroopak cherry-pick to master

@swaroopak swaroopak merged commit 8b81579 into apache:master Jun 16, 2021
@stoty
Copy link
Copy Markdown
Contributor

stoty commented Jun 17, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 ❌ mvninstall 17m 21s root in master failed.
+0 hbaserecompile 24m 47s HBase recompiled.
+1 💚 compile 1m 5s master passed
+1 💚 checkstyle 0m 33s master passed
+1 💚 javadoc 0m 53s master passed
+0 🆗 spotbugs 3m 21s phoenix-core in master has 965 extant spotbugs warnings.
_ Patch Compile Tests _
-1 ❌ mvninstall 9m 38s root in the patch failed.
+0 hbaserecompile 19m 59s HBase recompiled.
+1 💚 compile 1m 3s the patch passed
+1 💚 javac 1m 3s the patch passed
-1 ❌ checkstyle 0m 34s phoenix-core: The patch generated 12 new + 126 unchanged - 2 fixed = 138 total (was 128)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 50s the patch passed
+1 💚 spotbugs 3m 32s the patch passed
_ Other Tests _
-1 ❌ unit 114m 58s phoenix-core in the patch failed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
172m 53s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1248
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux 998cc1b94b45 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / b6d9338
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/testReport/
Max. process+thread count 11416 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani pushed a commit that referenced this pull request Jul 23, 2021
…rectly split page into tasks (#1240) (#1248)

* PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks

* Fix failing tests, add comments

* Break early when the matching set is found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants