PHOENIX-5422 Use Java8 DateTime APIs instead of joda-time APIs

[richardantal]

No description provided.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	5m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	16m 59s	master passed
+0	hbaserecompile	28m 35s	HBase recompiled.
+1 💚	compile	1m 38s	master passed
+1 💚	checkstyle	1m 10s	master passed
+1 💚	javadoc	1m 12s	master passed
+0 🆗	spotbugs	3m 6s	phoenix-core in master has 964 extant spotbugs warnings.
+0 🆗	spotbugs	0m 56s	phoenix-pherf in master has 54 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
-1 ❌	mvninstall	1m 13s	root in the patch failed.
+0	hbaserecompile	8m 31s	HBase recompiled.
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
-1 ❌	checkstyle	0m 48s	phoenix-core: The patch generated 96 new + 487 unchanged - 57 fixed = 583 total (was 544)
-1 ❌	checkstyle	0m 23s	phoenix-pherf: The patch generated 16 new + 265 unchanged - 15 fixed = 281 total (was 280)
-1 ❌	whitespace	0m 0s	The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	javadoc	1m 11s	the patch passed
-1 ❌	spotbugs	3m 19s	phoenix-core generated 6 new + 964 unchanged - 0 fixed = 970 total (was 964)
		_ Other Tests _
-1 ❌	unit	114m 46s	phoenix-core in the patch failed.
+1 💚	unit	8m 56s	phoenix-pherf in the patch passed.
-1 ❌	asflicense	1m 23s	The patch generated 1 ASF License warnings.
		182m 58s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.expression.function.RoundJavaDateExpression.correction should be package protected In RoundJavaDateExpression.java: In RoundJavaDateExpression.java
	org.apache.phoenix.expression.function.RoundJavaDateExpression.week should be package protected In RoundJavaDateExpression.java: In RoundJavaDateExpression.java
	Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.correction from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:[line 46]
	Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.week from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:[line 43]
	Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.correction from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:[line 46]
	Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.week from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:[line 43]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1277
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname	Linux cd5271c79f17 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 9b76bd5
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/whitespace-eol.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/testReport/
asflicense	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count	14994 (vs. ulimit of 30000)
modules	C: phoenix-core phoenix-pherf U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

Last time we discussed this, we decided to postpone this until 4.x is retired.
What is the reason that you have started to work on this again ?

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	5m 3s	Maven dependency ordering for branch
+1 💚	mvninstall	18m 7s	master passed
+0	hbaserecompile	30m 35s	HBase recompiled.
+1 💚	compile	1m 50s	master passed
+1 💚	checkstyle	1m 6s	master passed
+1 💚	javadoc	1m 21s	master passed
+0 🆗	spotbugs	3m 31s	phoenix-core in master has 964 extant spotbugs warnings.
+0 🆗	spotbugs	0m 55s	phoenix-pherf in master has 54 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	16m 9s	the patch passed
+0	hbaserecompile	23m 15s	HBase recompiled.
+1 💚	compile	1m 43s	the patch passed
+1 💚	javac	1m 43s	the patch passed
-1 ❌	checkstyle	0m 46s	phoenix-core: The patch generated 87 new + 471 unchanged - 75 fixed = 558 total (was 546)
-1 ❌	checkstyle	0m 23s	phoenix-pherf: The patch generated 13 new + 266 unchanged - 15 fixed = 279 total (was 281)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	1m 18s	the patch passed
-1 ❌	spotbugs	3m 43s	phoenix-core generated 6 new + 964 unchanged - 0 fixed = 970 total (was 964)
		_ Other Tests _
-1 ❌	unit	115m 28s	phoenix-core in the patch failed.
+1 💚	unit	9m 30s	phoenix-pherf in the patch passed.
+1 💚	asflicense	1m 16s	The patch does not generate ASF License warnings.
		202m 32s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.expression.function.RoundJavaDateExpression.correction should be package protected In RoundJavaDateExpression.java: In RoundJavaDateExpression.java
	org.apache.phoenix.expression.function.RoundJavaDateExpression.week should be package protected In RoundJavaDateExpression.java: In RoundJavaDateExpression.java
	Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.correction from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:[line 46]
	Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.week from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression() At RoundJavaDateExpression.java:[line 43]
	Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.correction from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:[line 46]
	Write to static field org.apache.phoenix.expression.function.RoundJavaDateExpression.week from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:from instance method new org.apache.phoenix.expression.function.RoundJavaDateExpression(List) At RoundJavaDateExpression.java:[line 43]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1277
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux 1233afd12a1c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 9b76bd5
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/testReport/
Max. process+thread count	13454 (vs. ulimit of 30000)
modules	C: phoenix-core phoenix-pherf U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1277/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.