Skip to content

PHOENIX-6600 Replace deprecated getCall with updated getRpcCall#1356

Merged
virajjasani merged 4 commits intoapache:masterfrom
kiran-maturi:PHOENIX-6600
Nov 29, 2021
Merged

PHOENIX-6600 Replace deprecated getCall with updated getRpcCall#1356
virajjasani merged 4 commits intoapache:masterfrom
kiran-maturi:PHOENIX-6600

Conversation

@kiran-maturi
Copy link
Copy Markdown
Contributor

No description provided.

@kiran-maturi kiran-maturi changed the title I PHOENIX-6600 fixes PhoenixRpcScheduler.dispatch getCall method not found PHOENIX-6600 fixes PhoenixRpcScheduler.dispatch getCall method not found Nov 22, 2021
@gjacoby126
Copy link
Copy Markdown
Contributor

@ArkenKiran - Looks like there are test failures (an NPE) with PhoenixIndexRpcSchedulerTest. Could you please take a look?

@kiran-maturi
Copy link
Copy Markdown
Contributor Author

@gjacoby126 Thanks for looking into it. I have fixed the test cases

@virajjasani
Copy link
Copy Markdown
Contributor

Test results for 2nd build: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1356/2/testReport/

Btw this PR and Jira title can be changed to "Replace deprecated getCall with updated getRpcCall" because method not found seems un-relevant.
And I will trigger one more build to ensure the recent failed tests are not repetitive (although they are known flakies).

@virajjasani virajjasani changed the title PHOENIX-6600 fixes PhoenixRpcScheduler.dispatch getCall method not found PHOENIX-6600 Replace deprecated getCall with updated getRpcCall Nov 26, 2021
@kiran-maturi
Copy link
Copy Markdown
Contributor Author

@virajjasani thanks for reviewing. The test are flaky in my local as well sometimes they fail and sometimes they pass

@virajjasani
Copy link
Copy Markdown
Contributor

The latest build looks good

Copy link
Copy Markdown
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani
Copy link
Copy Markdown
Contributor

@kiran-maturi could you also create another PR against 5.1 branch? That way we will have all tests run in 5.1 as well, and once done, both PRs can be merged together.

@virajjasani virajjasani merged commit fa15879 into apache:master Nov 29, 2021
virajjasani pushed a commit that referenced this pull request Nov 29, 2021
… (#1356)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
@kiran-maturi kiran-maturi deleted the PHOENIX-6600 branch November 29, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants