PHOENIX-6658 Replace HRegion.get() calls#1398
Closed
stoty wants to merge 4 commits intoapache:masterfrom
Closed
Conversation
joshelser
requested changes
Mar 1, 2022
Member
joshelser
left a comment
joshelser
left a comment
There was a problem hiding this comment.
The fix makes sense overall (switch over to using RegionScanner to take advantage of the off-heaping work in HBase as already written).
Istvan and I also talking about the value of looking at Phoenix now and trying to see how often we're doing unnecessary on-heap copies. He made https://issues.apache.org/jira/browse/PHOENIX-6621 for this. Made me wonder how we could measure the possible impact from off-heaping everything.
Comment on lines
+606
to
+608
| List<Cell> cells = new ArrayList<>(); | ||
| PhoenixKeyValueUtil.maybeCopyCellList(cells); | ||
| scanner.next(cells); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.