PHOENIX-6696 Drop legacy phoenix-client jar #1427
Conversation
stoty
requested review from
ankitsinghal,
apurtell,
gjacoby126,
joshelser and
virajjasani
|
Doesn't seem relevant to this PR but I see lots of |
|
Otherwise +1 for dropping phoenix-client and making only embedded jar available (target version only 5.2.x) |
gjacoby126
left a comment
gjacoby126
left a comment
There was a problem hiding this comment.
lgtm but one question about phoenix-tools
| </activation> | ||
| <modules> | ||
| <module>phoenix-client-parent</module> | ||
| <module>phoenix-client-parent/phoenix-client</module> |
There was a problem hiding this comment.
Drop phoenix-client-parent/phoenix-client directory and pom.xml too?
There was a problem hiding this comment.
We could.
However, I plan to have at least one more variant that that can coexist hbase-shaded-client (PHOENIX-6053), and it's easier to keep the structure than to remove and re-add it later.
If you feel strongly about it, then we certainly can remove this.
There was a problem hiding this comment.
Oh, you mean just the phoenix-client directory.
Sure.
Yes, we have a lot of those lately (we get that in our downstream tests, too). |
4 participants
No description provided.