Skip to content

PHOENIX-6985 Setting server-side masking flag default to false#1629

Merged
virajjasani merged 5 commits intoapache:masterfrom
lokiore:PHOENIX-6985
Jun 28, 2023
Merged

PHOENIX-6985 Setting server-side masking flag default to false#1629
virajjasani merged 5 commits intoapache:masterfrom
lokiore:PHOENIX-6985

Conversation

@lokiore
Copy link
Copy Markdown
Contributor

@lokiore lokiore commented Jun 19, 2023

No description provided.

@stoty
Copy link
Copy Markdown
Contributor

stoty commented Jun 20, 2023

Please make sure that the commit message has the JIRA id in the proper format.

@jpisaac jpisaac self-requested a review June 21, 2023 16:12
@jpisaac
Copy link
Copy Markdown
Contributor

jpisaac commented Jun 21, 2023

@lokiore The following JIRA title may be more appropriate or something along these -

"Setting server-side masking config default to false"

@lokiore lokiore changed the title PHOENIX-6985 :- Remove PhoenixTTLRegionObserver coproc being added by default on ever… PHOENIX-6985 :- Setting server-side masking flag default to false Jun 21, 2023
@lokiore
Copy link
Copy Markdown
Contributor Author

lokiore commented Jun 21, 2023

@jpisaac I see 2 test failures, one is passing locally and Failover one is failing even without the commit. Can you please take a look. I'll push an empty commit to rerun the tests.

@jpisaac
Copy link
Copy Markdown
Contributor

jpisaac commented Jun 26, 2023

@lokiore I understand they are flappers after talking to @virajjasani @tkhurana, Is there a way to mark them as such?

Copy link
Copy Markdown
Contributor

@jpisaac jpisaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@lokiore
Copy link
Copy Markdown
Contributor Author

lokiore commented Jun 26, 2023

@lokiore I understand they are flappers after talking to @virajjasani @tkhurana, Is there a way to mark them as such?

I am not sure if we can do something here other than Ignore which I assume we don't want. maybe some plugin can be added at jenkins like Result Test Analyser or do we already have that @virajjasani !?

Copy link
Copy Markdown
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani virajjasani changed the title PHOENIX-6985 :- Setting server-side masking flag default to false PHOENIX-6985 Setting server-side masking flag default to false Jun 27, 2023
@virajjasani
Copy link
Copy Markdown
Contributor

@jpisaac we want this in 5.1 too?

@lokiore
Copy link
Copy Markdown
Contributor Author

lokiore commented Jun 28, 2023

@virajjasani create PR for 5.1 to let tests run :- #1634

@virajjasani virajjasani merged commit 2dab085 into apache:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants