PHOENIX-6942: Some config properties do not have phoenix prefix #1656
Conversation
Aarchy
force-pushed
the
prefix
branch
3 times, most recently
from
6d88671 to
50710ae
Compare
| "|org.apache.phoenix.index.GlobalIndexChecker|805306365|"; | ||
| public static final String INDEX_REGION_OBSERVER_CONFIG = | ||
| "|org.apache.phoenix.hbase.index.IndexRegionObserver|805306366|" + | ||
| "index.builder=org.apache.phoenix.index.PhoenixIndexBuilder," + |
There was a problem hiding this comment.
index.builder and org.apache.hadoop.hbase.index.codec.class are present in the HBase table descriptor.
For data backwards compatibility reasons I'd prefer not change these two (even though they have the same problems as others).
i.e. Changing these would break older versions of Phoenix when trying to use them if we changed these.
There was a problem hiding this comment.
And these are not read from hbase-site.xml, but from the Hbase table metadata directly.
There was a problem hiding this comment.
Thank you for pointing this out, will restore the original strings.
The string "index.builder" was declared twice though, I think one of them was unnecessary.
There was a problem hiding this comment.
Can you revert the whitespace changes ?
If we don't change these, it's better to leave the file alone.
stoty
left a comment
stoty
left a comment
There was a problem hiding this comment.
Some nits and whitespace issues
| "|org.apache.phoenix.index.GlobalIndexChecker|805306365|"; | ||
| public static final String INDEX_REGION_OBSERVER_CONFIG = | ||
| "|org.apache.phoenix.hbase.index.IndexRegionObserver|805306366|" + | ||
| "index.builder=org.apache.phoenix.index.PhoenixIndexBuilder," + |
There was a problem hiding this comment.
Can you revert the whitespace changes ?
If we don't change these, it's better to leave the file alone.
|
|
||
| private static final int DEFAULT_ROWLOCK_WAIT_DURATION = 30000; | ||
| private static final int DEFAULT_CONCURRENT_MUTATION_WAIT_DURATION_IN_MS = 100; | ||
|
|
There was a problem hiding this comment.
nit: don't delete the empty line
| .encodeVersion("0.94.9"); | ||
|
|
||
| private static final int DEFAULT_ROWLOCK_WAIT_DURATION = 30000; | ||
|
|
There was a problem hiding this comment.
nit: don't delete the empty line
2 participants
No description provided.