PHOENIX-7270 : Always resolve table before DDL operations#1854
Merged
shahrs87 merged 7 commits intoapache:PHOENIX-6883-featurefrom Mar 15, 2024
Merged
PHOENIX-7270 : Always resolve table before DDL operations#1854shahrs87 merged 7 commits intoapache:PHOENIX-6883-featurefrom
shahrs87 merged 7 commits intoapache:PHOENIX-6883-featurefrom
Conversation
shahrs87
reviewed
Mar 14, 2024
phoenix-core/src/test/java/org/apache/phoenix/cache/ServerMetadataCacheIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/test/java/org/apache/phoenix/cache/ServerMetadataCacheIT.java
Outdated
Show resolved
Hide resolved
shahrs87
reviewed
Mar 14, 2024
|
|
||
| public static ColumnResolver getResolver(SingleTableStatement statement, PhoenixConnection connection) | ||
| throws SQLException { | ||
| SingleTableColumnResolver visitor = new SingleTableColumnResolver(connection, statement.getTable(), true); |
Contributor
There was a problem hiding this comment.
Do we use one of these resolvers when we run ALTER TABLE <table-name> SET PROPERTY statement?
Contributor
Author
There was a problem hiding this comment.
Yes.
Confirmed from SetPropertyIT that setting property on table/view goes through ExecutableAddColumnStatement and that uses the resolver change we made.
…dataCacheIT.java Co-authored-by: Rushabh Shah <shahrs87@apache.org>
shahrs87
approved these changes
Mar 14, 2024
Contributor
shahrs87
left a comment
shahrs87
left a comment
There was a problem hiding this comment.
+1 ltgm.
Will merge once jenkins is green.
Contributor
Author
|
@shahrs87 Pushed some checkstyle fixes, test results looked good - https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1854/5/testReport/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.