PHOENIX-7166 : Enable feature flags introduced by metadata caching redesign #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 19, 2024 13:58
This reverts commit 5d59a8c.
Contributor
Author
|
@shahrs87 Let me know if we can get this one in now? |
shahrs87
reviewed
Apr 8, 2024
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java
Outdated
Show resolved
Hide resolved
added 5 commits
April 8, 2024 13:20
shahrs87
requested changes
Apr 11, 2024
phoenix-core-client/src/main/java/org/apache/phoenix/util/ValidateLastDDLTimestampUtil.java
Outdated
Show resolved
Hide resolved
phoenix-core-client/src/main/java/org/apache/phoenix/util/ValidateLastDDLTimestampUtil.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpdateCacheAcrossDifferentClientsIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
Outdated
Show resolved
Hide resolved
shahrs87
requested changes
Apr 12, 2024
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/LogicalTableNameBaseIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/LogicalTableNameExtendedIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexAsyncThresholdIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/query/MetaDataCachingIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/test/java/org/apache/phoenix/jdbc/ParallelPhoenixConnectionFailureTest.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/test/java/org/apache/phoenix/query/BaseConnectionlessQueryTest.java
Outdated
Show resolved
Hide resolved
palashc
commented
Apr 12, 2024
phoenix-core/src/it/java/org/apache/phoenix/end2end/LoadSystemTableSnapshotIT.java
Outdated
Show resolved
Hide resolved
palashc
commented
Apr 12, 2024
phoenix-core/src/it/java/org/apache/phoenix/jdbc/HighAvailabilityTestingUtility.java
Outdated
Show resolved
Hide resolved
shahrs87
reviewed
Apr 17, 2024
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
Outdated
Show resolved
Hide resolved
shahrs87
reviewed
Apr 17, 2024
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java
Outdated
Show resolved
Hide resolved
shahrs87
reviewed
Apr 17, 2024
phoenix-core/src/it/java/org/apache/phoenix/query/MetaDataCachingIT.java
Outdated
Show resolved
Hide resolved
shahrs87
reviewed
Apr 17, 2024
phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheConnectionLevelPropIT.java
Show resolved
Hide resolved
shahrs87
reviewed
Apr 17, 2024
phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java
Outdated
Show resolved
Hide resolved
shahrs87
reviewed
Apr 18, 2024
| private static final Logger LOGGER = LoggerFactory.getLogger(MetaDataCachingIT.class); | ||
| private final Random RAND = new Random(11); | ||
|
|
||
| private boolean isLastDDLTimestampValidationEnabled = config.getBoolean( |
Contributor
There was a problem hiding this comment.
Instead of duplicating this line in 3 different tests, do you mind creating a util method in ValidateLastDDLTimestampUtil something like getValidateLastDdlTimestampEnabled(Configuration config) similar to getValidateLastDdlTimestampEnabled(PhoenixConnection connection)
shahrs87
reviewed
Apr 18, 2024
| public static ColumnResolver getResolver(SingleTableStatement statement, PhoenixConnection connection, Map<String, UDFParseNode> udfParseNodes) | ||
| throws SQLException { | ||
| SingleTableColumnResolver visitor = new SingleTableColumnResolver(connection, statement.getTable(), true, 0, udfParseNodes); | ||
| SingleTableColumnResolver visitor |
Contributor
There was a problem hiding this comment.
I see that we are calling this resolver from MetaDataClient#createIndex and CreateIndexCompiler#compile method. So we want to bypass cache for createIndex and resolve table always. So lets rename this method to getResolverForCreateIndex and add a comment on why we are setting alwaysHitServer to true.
Contributor
Author
|
@shahrs87 Latest test report - https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1859/22/testReport/ |
shahrs87
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.