Merged
Conversation
virajjasani
approved these changes
Feb 3, 2026
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
+1, pending build results
richardantal
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to add some tests in IndexToolIT but due to these static initializations
public final static String OUTPUT_TABLE_NAME = IndexToolTableUtil.OUTPUT_TABLE_FULL_NAME;and
public static String RESULT_TABLE_NAME = IndexToolTableUtil.RESULT_TABLE_FULL_NAME;my tests were facing a TNFE for
SYSTEM.PHOENIX_INDEX_TOOLwhen namespace mapping is enabled. IndexToolIT runs tests with namespaceMapped=false before running tests with namespaceMapped=true and hence those constants were set toSYSTEM.PHOENIX_INDEX_TOOLinstead ofSYSTEM:PHOENIX_INDEX_TOOL