PHOENIX-7276 Add REGEXP_LIKE built-in function#2398
Conversation
|
Test cases : https://gist.github.com/xavifeds8/277363033cb44e18eeddf44894c038ca |
22cc7dd to
b20485e
Compare
|
@virajjasani can you please review this PR ? |
|
Nice, can we also document what is the main difference b/ this function and |
|
Triggered a new build since the last build timed out https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2398/ |
|
@sanjeet006py if you would also like to take a look? |
|
@xavifeds8 could you run |
Hey @virajjasani thanks for pointing it out. I have fixed the spotless issue now it should be good. 👍 |
sanjeet006py
left a comment
There was a problem hiding this comment.
Thanks. LGTM overall just one comment.
Adds REGEXP_LIKE(source_string, pattern [, match_parameter]) function that tests whether a string matches a regular expression pattern and returns a boolean result. Uses full-match semantics consistent with Hive/Spark.
…sion Added comprehensive Javadoc comparison explaining pattern syntax, complexity, flags, performance differences and examples.
|
Thanks @xavifeds8 and @sanjeet006py! @xavifeds8 feel free to create backport PR for 5.3 as well |
Thanks @virajjasani and @sanjeet006py! Appreciate the merge and review. Happy to contribute to Phoenix 👍 . @virajjasani I have raised another PR as a backport for 5.3 (#2422) can you please check. |
Adds REGEXP_LIKE(source_string, pattern [, match_parameter]) function that tests whether a string matches a regular expression pattern and returns a boolean result. Uses full-match semantics consistent with Hive/Spark.