PHOENIX-7944 (addendum) Move bcprov-jdk18on unused-declared ignore into phoenix-core pom#2554
Merged
Merged
Conversation
…to phoenix-core pom
The original fix added the ignore entries to the root pom's
maven-dependency-plugin config (under pluginManagement). However
phoenix-core/pom.xml re-declares the plugin under build/plugins with its
own non-empty <ignoredUnusedDeclaredDependencies> list, which overrides
(does not merge with) the parent's list. As a result the parent-level
bcprov-jdk18on entry never applied to phoenix-core, and the 2.6.0 profile
release still failed at analyze-only with:
Unused declared: org.bouncycastle:bcprov-jdk18on:jar:1.79:test
The companion bcprov-jdk15on used-undeclared ignore kept working because
phoenix-core's <ignoredUsedUndeclaredDependencies/> is empty, so the
parent entry passed through.
Add the bcprov-jdk18on entry directly to phoenix-core's child list so the
ignore actually applies. Verified locally with
mvn -Dhbase.profile=2.6.0 -pl phoenix-core \
dependency:analyze-only@enforce-dependencies
-> No dependency problems found / BUILD SUCCESS.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addendum to PHOENIX-7944
The original PHOENIX-7944 fix (#2552) added the bouncycastle ignore entries to the root pom's
maven-dependency-pluginconfiguration (under<build><pluginManagement>). The 5.3.2RC2 release built from that fix still failed on the2.6.0HBase profile at thephoenix-coreanalyze-only (enforce-dependencies)step:Root cause
phoenix-core/pom.xmlre-declaresmaven-dependency-pluginunder<build><plugins>with its own non-empty<ignoredUnusedDeclaredDependencies>list. A non-empty child element overrides (does not merge with) the inheritedpluginManagementlist, so the parent-levelbcprov-jdk18onentry never applied tophoenix-core.The companion
bcprov-jdk15onused-undeclared ignore kept working only becausephoenix-core's<ignoredUsedUndeclaredDependencies/>is empty/self-closing — so that parent entry passed through. That asymmetry is exactly why RC2 showed only the one remaining error.Fix
Add
org.bouncycastle:bcprov-jdk18ondirectly tophoenix-core's child<ignoredUnusedDeclaredDependencies>list, next to the existing slf4j/log4j entries. The parent-pombcprov-jdk15onentry stays (still required); the now-redundant parentbcprov-jdk18onentry is harmless.Verification
Ran the exact release check locally on this branch under the failing profile:
Also audited all modules: only
phoenix-coreboth declaresbcprov-jdk18onand overrides the ignore list.phoenix-core-clienthas no plugin<configuration>(inherits the parent list);phoenix-core-serveruses<ignoreNonCompile>true</ignoreNonCompile>. Both are unaffected.🤖 Generated with Claude Code