Skip to content

PHOENIX-4791 Propagate projected array elements through hash join #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
geraldss wants to merge 6 commits into from
Closed

PHOENIX-4791 Propagate projected array elements through hash join #335

geraldss wants to merge 6 commits into from

Conversation

@geraldss
Copy link

@geraldss geraldss commented Aug 23, 2018

No description provided.

twdsilva
twdsilva reviewed Aug 30, 2018
View reviewed changes
Copy link
Contributor

@twdsilva twdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geraldss I am not very familiar wit the join code, but the changes look good to me. Can you please squash your commits and attach a patch to the JIRA and click submit so that we get a test run?

phoenix-core/src/it/java/org/apache/phoenix/end2end/ProjectArrayElemAfterHashJoinIT.java
}
}

private void dropTable(Connection conn, String table) throws Exception {
Copy link
Contributor

@twdsilva twdsilva Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to drop table since you are creating creating table with unique names.

Copy link
Author

@geraldss geraldss Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twdsilva . I submitted the patch.

I left the dropTable() in there if it's harmless. Lmk if it's a problem.

Copy link
Contributor

@twdsilva twdsilva Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropTable() just slows the test down. We prevent too many tables from being created by starting a new minicluster after a certain threshold (see .BaseTest.tearDownMiniClusterIfBeyondThreshold() )

Copy link
Contributor

@JamesRTaylor JamesRTaylor Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pursuing a fix for this issue, @geraldss. If you could please submit a new patch without the dropTable() call, we'd appreciate it.

Copy link
Author

@geraldss geraldss Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @twdsilva @JamesRTaylor, done. Thanks for the review.

@geraldss geraldss closed this Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twdsilva twdsilva twdsilva left review comments

+1 more reviewer

@JamesRTaylor JamesRTaylor JamesRTaylor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geraldss @twdsilva @JamesRTaylor