PHOENIX-4983: Allow using a connection with a SCN set to write data to tables EXCEPT transactional tables or mutable tables with indexes or tables with ROW_TIMESTAMP column. #405
Conversation
swaroopak
force-pushed
the
PHOENIX-4983
branch
from
7e94cd4 to
fa96a5c
Compare
twdsilva
left a comment
twdsilva
left a comment
There was a problem hiding this comment.
@swaroopak thanks for the PR, I have left some feedback.
|
|
||
| } | ||
| @Test | ||
| public void testUpsertOnSCNSetMutTable() throws Exception { |
There was a problem hiding this comment.
add a helper function to test the tables that are mutable/immutable and which don't have an index, have a global index or a local index (and pass these options in as parameters).
| @Test // See https://issues.apache.org/jira/browse/PHOENIX-4983 | ||
| public void testUpsertOnSCNSetTxnTable() throws SQLException { | ||
|
|
||
| String trnx = "CREATE TABLE transaction_table (METRIC_ID CHAR(15) NOT NULL,\n" + |
There was a problem hiding this comment.
Use a generateUniqueName() to create tables with unique names since tests that extend ParallelStatsDisabledIT
share the same cluster.
| CANNOT_UPSERT_WITH_SCN_FOR_ROW_TIMSTAMP_COLUMN(901,"43M12", | ||
| "Cannot use a connection with SCN set to upsert data for " + | ||
| "table with ROW_TIMESTAMP column."), | ||
| CANNOT_UPSERT_WITH_SCN_FOR_TXN_TABLE(902,"43M13", |
There was a problem hiding this comment.
remove this as its not used
| if (plan.getTargetRef() != null && plan.getTargetRef().getTable() != null && plan.getTargetRef().getTable().isTransactional()) { | ||
| state.startTransaction(plan.getTargetRef().getTable().getTransactionProvider()); | ||
| PTable table = plan.getTargetRef().getTable(); | ||
| if(table != null && connection.getSCN() != null && !connection.isRunningUpgrade() && !connection.isBuildingIndex()) { |
There was a problem hiding this comment.
can you move these checks to UpsertCompiler? Also I think you can remove the second check for mutable tables with indexes here.
swaroopak
force-pushed
the
PHOENIX-4983
branch
2 times, most recently
from
c6ce8be to
c19b2a7
Compare
|
|
||
| helpTestUpserWithSCNIT(false, true, false, false, false); | ||
| exception.expect(SQLException.class); | ||
| exception.expectMessage(containsString("ERROR 1075 (44A06): Cannot use a " + |
There was a problem hiding this comment.
don't compare error message strings, use errorCode instead.
twdsilva
left a comment
twdsilva
left a comment
There was a problem hiding this comment.
@swaroopak looks good, please make the change that karan requested and we can get this committed.
| } | ||
|
|
||
| @Test | ||
| public void testUpsertOnSCNSetMutTable() throws Exception { |
There was a problem hiding this comment.
nit: rename to testUpsertOnSCNSetMutableTableWithoutIndexes
swaroopak
force-pushed
the
PHOENIX-4983
branch
2 times, most recently
from
cda3ff6 to
6a6c858
Compare
|
+1 |
…o tables EXCEPT transactional tables or mutable tables with indexes or tables with ROW_TIMESTAMP column.
swaroopak
force-pushed
the
PHOENIX-4983
branch
from
6a6c858 to
03b746c
Compare
3 participants
…