PHOENIX-4285 Add PHERF.LOG_PER_NROWS constraint to PHERF.properties file #518
Conversation
|
Added a getProperties function in order to have functional tests. |
| exit.expectSystemExitWithStatus(1); | ||
| Pherf.main(args); | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't see a test for bad values of this passed in, non-integer negative etc.
| String[] args = {"-listFiles"}; | ||
| Pherf pherf = new Pherf(args); | ||
| Properties prop = pherf.getProperties(); | ||
| assertEquals(Long.valueOf(PherfConstants.LOG_PER_NROWS), |
There was a problem hiding this comment.
Having a constant called LOG_PER_NROWS and another called LOG_PER_N_ROWS in the same class is pretty confusing, especially when one refers to a key and the other to a value. :-)
There was a problem hiding this comment.
Will change LOG_PER_N_ROWS to LOG_PER_NROWS_NAME
| PherfConstants constants = PherfConstants.create(); | ||
| assertNotNull(constants.getProperty("pherf.default.dataloader.threadpool")); | ||
| assertNotNull(constants.getProperty("pherf.default.results.dir")); | ||
| assertNotNull(constants.getProperty("pherf.default.log_per_nrows")); |
There was a problem hiding this comment.
Should use constant for the string
There was a problem hiding this comment.
used constant PherfConstants.LOG_PER_NROWS_NAME instead of string
|
Thanks for the reviewing @dbwong @gjacoby126 :) |
|
do you have any suggestions here @gjacoby126 |
3 participants
No description provided.