PHOENIX-5395: IndexUpgradeTool passes data table instead of view for …#546
Closed
swaroopak wants to merge 1 commit intoapache:4.x-HBase-1.3from
Closed
PHOENIX-5395: IndexUpgradeTool passes data table instead of view for …#546swaroopak wants to merge 1 commit intoapache:4.x-HBase-1.3from
swaroopak wants to merge 1 commit intoapache:4.x-HBase-1.3from
Conversation
priyankporwal
suggested changes
Jul 18, 2019
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
Outdated
Show resolved
Hide resolved
| return 0; | ||
| } | ||
|
|
||
| private String[] getArgValues(String schema, String baseTable, String indexName, |
Contributor
There was a problem hiding this comment.
Also, perhaps rename to getIndexToolArgValues?
Contributor
Author
There was a problem hiding this comment.
I got this idea while I was going through one of the ITs, it was named such and hence picked for consistency. But, I get your point.
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
Outdated
Show resolved
Hide resolved
priyankporwal
approved these changes
Jul 22, 2019
…post upgrade view index rebuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…post upgrade view index rebuild