Phoenix 5420 Implement trimb build-in function for BINARY and VARBINARY#561
Closed
vikashtalanki wants to merge 4 commits intoapache:masterfrom
Closed
Phoenix 5420 Implement trimb build-in function for BINARY and VARBINARY#561vikashtalanki wants to merge 4 commits intoapache:masterfrom
vikashtalanki wants to merge 4 commits intoapache:masterfrom
Conversation
added 2 commits
August 2, 2019 13:09
yanxinyi
reviewed
Aug 2, 2019
Contributor
There was a problem hiding this comment.
line more than 100 chars, plz follow the code conventions
FYI: https://phoenix.apache.org/contributing.html
yanxinyi
reviewed
Aug 2, 2019
Contributor
There was a problem hiding this comment.
all your test method has this resultString var = "ABC", better to have as a global variable?
added 2 commits
August 3, 2019 00:08
PHOENIX-5420:Implement trimb build-in function for BINARY and VARBINARY - Added FunctionTest PHOENIX-5420:Implement trimb build-in function for BINARY and VARBINARY
…RY - Code conventions followed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.