PHOENIX-5615 Index read repair should delete all the cells of an inva…#652
Closed
kadirozde wants to merge 1 commit intoapache:masterfrom
kadirozde:5615
Closed
PHOENIX-5615 Index read repair should delete all the cells of an inva…#652kadirozde wants to merge 1 commit intoapache:masterfrom kadirozde:5615
kadirozde wants to merge 1 commit intoapache:masterfrom
kadirozde:5615
Conversation
…lid unverified row
gjacoby126
approved these changes
Dec 12, 2019
| Delete del = new Delete(indexRowKey, ts); | ||
| if (specific) { | ||
| // Get all the cells of this row | ||
| deleteRowScan.withStartRow(indexRowKey, true); |
Contributor
There was a problem hiding this comment.
hmm...if you knew for sure what the CFs were you could probbaly do addFamilyVersion in a loop instead, possibly saving yourself a Scan. You wouldn't have to worry about dynamic columns (can't be indexed), but you'd need a PTable for getColumnFamilies, and to know for sure it was up to date as of the timestamp you're deleting.
I'm going to approve as-is, just thinking out loud here.
Contributor
Author
There was a problem hiding this comment.
It is safer to retrieve the columns to find out their timestamps and delete markers for these timestamps, at least for now. We can think about your suggestion in future.
gokceni
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lid unverified row