PHOENIX-5723 PhoenixIndexImportDirectReducer cleanup method updates i…#705
Closed
tkhurana wants to merge 2 commits intoapache:masterfrom
Closed
PHOENIX-5723 PhoenixIndexImportDirectReducer cleanup method updates i…#705tkhurana wants to merge 2 commits intoapache:masterfrom
tkhurana wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
Contributor
|
Could you please add a test for this? |
gokceni
reviewed
Feb 12, 2020
...x-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java
Outdated
Show resolved
Hide resolved
gokceni
reviewed
Feb 12, 2020
...x-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java
Show resolved
Hide resolved
gokceni
reviewed
Feb 12, 2020
| } | ||
| } | ||
|
|
||
| private void updateTasksTable(Context context) throws SQLException, IOException { |
Contributor
There was a problem hiding this comment.
Please don't remove this method. Removing will cause IndexRebuildTaskIT to fail.
gokceni
suggested changes
Feb 12, 2020
Contributor
gokceni
left a comment
gokceni
left a comment
There was a problem hiding this comment.
updateTaskTable method should not be removed and it should be called.
tkhurana
force-pushed
the
PHOENIX-5723
branch
from
66a0374 to
e5ed046
Compare
…ndex state to active
tkhurana
force-pushed
the
PHOENIX-5723
branch
from
e5ed046 to
3848fb3
Compare
gokceni
reviewed
Feb 13, 2020
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java
Show resolved
Hide resolved
gokceni
approved these changes
Feb 13, 2020
swaroopak
approved these changes
Feb 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ndex state to active