PHOENIX-5673 : The mutation state is silently getting cleared on the … #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChinmaySKulkarni
requested changes
Feb 24, 2020
Contributor
ChinmaySKulkarni
left a comment
ChinmaySKulkarni
left a comment
There was a problem hiding this comment.
@siddhimehta overall looks good. I have a few comments. Just to make sure, can we also test this with view creation and view index creation. Currently it looks like we have a test for just table creation (no need to add new tests for these cases, but let's just check it works as expected).
phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationStateIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationStateIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/test/java/org/apache/phoenix/execute/MutationStateTest.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/test/java/org/apache/phoenix/execute/MutationStateTest.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/test/java/org/apache/phoenix/execute/MutationStateTest.java
Outdated
Show resolved
Hide resolved
siddhimehta
force-pushed
the
PHOENIX-5673
branch
from
8741838 to
3d28778
Compare
Contributor
Author
|
@ChinmaySKulkarni Tested view creation and index creation also |
| ensureTableCreated(getUrl(), tableName, TestUtil.PTSDB_NAME, null, null, null); | ||
| Properties props = new Properties(); | ||
| props.setProperty(QueryServices.PENDING_MUTATIONS_DDL_THROW_ATTRIB, Boolean.toString(true)); | ||
| Connection conn = DriverManager.getConnection(getUrl(), props); |
Contributor
There was a problem hiding this comment.
nit: try-with-resources to auto-close connection and statement.
siddhimehta
force-pushed
the
PHOENIX-5673
branch
from
3d28778 to
d8399e0
Compare
ChinmaySKulkarni
approved these changes
Mar 6, 2020
Contributor
ChinmaySKulkarni
left a comment
ChinmaySKulkarni
left a comment
There was a problem hiding this comment.
+1 thanks @siddhimehta
…execution of any DDL
siddhimehta
force-pushed
the
PHOENIX-5673
branch
from
d8399e0 to
3e0bb9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChinmaySKulkarni @abhishek-chouhan Creating this PR to get feedback on the approach.
I have added a config to enable this behaviour ( default false).
Ran all the IT locally for the same