PHOENIX-5875 - Optional logging for IndexTool verification#782
Merged
gjacoby126 merged 1 commit intoapache:4.xfrom May 22, 2020
Merged
PHOENIX-5875 - Optional logging for IndexTool verification#782gjacoby126 merged 1 commit intoapache:4.xfrom
gjacoby126 merged 1 commit intoapache:4.xfrom
Conversation
kadirozde
reviewed
May 19, 2020
| } | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
These tests should move into IndexToolForNonTxGlobalIndexIT after the recent restructuring of IndexToolIT
|
|
||
| private static final Option DISABLE_LOGGING_OPTION = new Option("dl", | ||
| "disable-logging", true | ||
| , "Disable logging of failed verification rows for BEFORE, " + |
Contributor
There was a problem hiding this comment.
So, we cannot disable logging for ONLY mode?
swaroopak
reviewed
May 19, 2020
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
Show resolved
Hide resolved
gokceni
reviewed
May 21, 2020
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java
Outdated
Show resolved
Hide resolved
gokceni
reviewed
May 21, 2020
| IndexDisableLoggingType loggingDisableType = IndexDisableLoggingType.fromValue(loggingDisableValue); | ||
| if (loggingDisableType != IndexDisableLoggingType.BEFORE && | ||
| loggingDisableType != IndexDisableLoggingType.AFTER && | ||
| loggingDisableType != IndexDisableLoggingType.BOTH) { |
gjacoby126
force-pushed
the
PHOENIX-5875
branch
2 times, most recently
from
3943ce2 to
242515f
Compare
Contributor
Author
|
A few test flappers and minicluster crashes happened on the Pre-Commit job. Reran them manually locally and they passed, so I'm going to commit this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.