PHOENIX-6059 Adding more pagination tests#850
Closed
yanxinyi wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@dbwong please take a look this additional tests for the RVC feature |
Contributor
|
Overall whats there look good for initial. I think we may want to add at least some views to the set of tables as I looked closer and did not see view/tenant views. What do you think? |
dbwong
approved these changes
Aug 11, 2020
Contributor
dbwong
left a comment
dbwong
left a comment
There was a problem hiding this comment.
Some description is needed i think but rest looks okay. Address nits and +1.
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| public class RowValueConstructorOffsetOptionalIT extends ParallelStatsDisabledIT { |
Contributor
There was a problem hiding this comment.
Nit: Describe test and why its "ignored" here. Rest looks okay to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.