PHOENIX-5261: Implement ALTER TABLE ADD COLUMN CASCADE #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaroopak
force-pushed
the
PHOENIX-5261
branch
from
c76a533 to
ca33eed
Compare
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterAddCascadeIndexIT.java
Outdated
Show resolved
Hide resolved
gokceni
reviewed
Sep 16, 2020
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterAddCascadeIndexIT.java
Outdated
Show resolved
Hide resolved
gokceni
reviewed
Sep 16, 2020
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
Show resolved
Hide resolved
gokceni
reviewed
Sep 16, 2020
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
Outdated
Show resolved
Hide resolved
gokceni
reviewed
Sep 16, 2020
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
Outdated
Show resolved
Hide resolved
gjacoby126
reviewed
Sep 16, 2020
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterAddCascadeIndexIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterAddCascadeIndexIT.java
Outdated
Show resolved
Hide resolved
swaroopak
force-pushed
the
PHOENIX-5261
branch
2 times, most recently
from
80656f1 to
07e2230
Compare
priyankporwal
approved these changes
Sep 17, 2020
Contributor
priyankporwal
left a comment
priyankporwal
left a comment
There was a problem hiding this comment.
+1 @swaroopak. Thanks for implementing this feature!
gokceni
approved these changes
Sep 18, 2020
swaroopak
force-pushed
the
PHOENIX-5261
branch
from
f1f8b61 to
54e356f
Compare
gjacoby126
approved these changes
Sep 21, 2020
Contributor
gjacoby126
left a comment
gjacoby126
left a comment
There was a problem hiding this comment.
Looks good. Just one small additional test case, then +1.
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterAddCascadeIndexIT.java
Show resolved
Hide resolved
swaroopak
force-pushed
the
PHOENIX-5261
branch
from
54e356f to
6a73728
Compare
swaroopak
added a commit
that referenced
this pull request
Sep 21, 2020
Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
jpisaac
pushed a commit
to jpisaac/phoenix
that referenced
this pull request
Oct 1, 2020
Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.