Broken Metrics for Tracking Segments Missing Deepstore Link in Controller #16315
Description
In #10725 I had added a metric for tracking segments missing deep-store link. But I saw today that this metric is not updated, because when deepstore upload fails, segment location may be set to "peer" instead of being empty.
As part of this ticket we need someone to verify this is the case and raise a fix.
For verification, this is the log I had seen in one of our servers. If someone can double check the code once to see how this is computed that should be good enough.
Could not send request http://host:port/segmentCommitEndWithMetadata?segmentSizeBytes=428659734&reason=rowLimit&buildTimeMillis=47707&streamPartitionMsgOffset=11095214569&instance=xyz&offset=-1&name=my_table__93__11890__20250709T1522Z&location=peer%3A%2F%2F%my_table__93__11890__20250709T1522Z&rowCount=435194&memoryUsedBytes=902177931