-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Open
Description
Currently there are three issues with SegmentNameGenerator classes -
-
The implementations need to be supplied with exact arguments instead of general segment name generator config. e.g. You need to provide
dateTimeFormatSpec,pushType,excludeSequenceIdetc. but instead you can simply passsegmentNameGeneratorConfigto the constructor and let the implementation take care of extracting out props. -
Any change to segmentName logic requires changing the implementation classes. We can rely on something like templates to generate the segment name rather than having to implement code change.
-
A lot of segment name generator props are duplicates in
BatchConfigPropertiesas well. Addressing 1 should also help addresses this.
Metadata
Metadata
Assignees
Labels
No labels