Skip to content

Refactor Segment Name Generator #8799

@KKcorps

Description

@KKcorps

Currently there are three issues with SegmentNameGenerator classes -

  • The implementations need to be supplied with exact arguments instead of general segment name generator config. e.g. You need to provide dateTimeFormatSpec, pushType , excludeSequenceId etc. but instead you can simply pass segmentNameGeneratorConfig to the constructor and let the implementation take care of extracting out props.

  • Any change to segmentName logic requires changing the implementation classes. We can rely on something like templates to generate the segment name rather than having to implement code change.

  • A lot of segment name generator props are duplicates in BatchConfigProperties as well. Addressing 1 should also help addresses this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions