Make BaseDefaultColumnHandler constructor safe for SegmentMetadata initialised with IS#10016
Closed
saurabhd336 wants to merge 1 commit intoapache:masterfrom
Closed
Make BaseDefaultColumnHandler constructor safe for SegmentMetadata initialised with IS#10016saurabhd336 wants to merge 1 commit intoapache:masterfrom
saurabhd336 wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10016 +/- ##
=============================================
+ Coverage 28.05% 70.34% +42.28%
- Complexity 53 5682 +5629
=============================================
Files 1979 1991 +12
Lines 106930 107284 +354
Branches 16277 16316 +39
=============================================
+ Hits 30001 75467 +45466
+ Misses 73993 26544 -47449
- Partials 2936 5273 +2337
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
needPrerocesscalls, we don't need metadata files. This changes makes it possible to initialise BaseDefaultColumnHandler with Inputstream based SegmentMetadata implementations.