[multistage][hotfix] fix limit pushdown only keep 10_000 rows#10224
Merged
walterddr merged 1 commit intoapache:masterfrom Feb 2, 2023
Merged
[multistage][hotfix] fix limit pushdown only keep 10_000 rows#10224walterddr merged 1 commit intoapache:masterfrom
walterddr merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
CC @agavra |
walterddr
force-pushed
the
pr_hotfix_sort_pushdown_limit
branch
from
dbef698 to
41c3172
Compare
Jackie-Jiang
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously sort is hard-coded to have limit 10_000. we should not limit on this. this will cause
SELECT * FROM tbl LIMIT 100000to only return 10_000 rows.