close startree index properly#10265
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Feb 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10265 +/- ##
============================================
- Coverage 70.40% 68.46% -1.94%
+ Complexity 5771 5763 -8
============================================
Files 2017 2017
Lines 109288 109291 +3
Branches 16614 16614
============================================
- Hits 76939 74825 -2114
- Misses 26947 29127 +2180
+ Partials 5402 5339 -63
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close startree index properly to avoid potential resource leakage, which is not happening today as all resource is released upon SegmentDirectory.close. But hook up the close() calls properly in case StarTree instances will have its own resource later on.