Add the support of Apache Pulsar for StreamGithubEventsCommand#10308
Merged
snleee merged 2 commits intoapache:masterfrom Feb 21, 2023
Merged
Add the support of Apache Pulsar for StreamGithubEventsCommand#10308snleee merged 2 commits intoapache:masterfrom
snleee merged 2 commits intoapache:masterfrom
Conversation
snleee
force-pushed
the
pulsar-github-producer
branch
2 times, most recently
from
89fc533 to
7c4e66d
Compare
Make the command to be able to publish data to Apache Pulsar cluster.
snleee
force-pushed
the
pulsar-github-producer
branch
from
7c4e66d to
5106f20
Compare
Codecov Report
@@ Coverage Diff @@
## master #10308 +/- ##
============================================
- Coverage 68.41% 68.24% -0.18%
- Complexity 5109 5860 +751
============================================
Files 2015 2027 +12
Lines 109656 110064 +408
Branches 16686 16716 +30
============================================
+ Hits 75024 75114 +90
- Misses 29283 29584 +301
- Partials 5349 5366 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KKcorps
approved these changes
Feb 20, 2023
Contributor
KKcorps
left a comment
KKcorps
left a comment
There was a problem hiding this comment.
One comment. Overall, LGTM!
...ot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/server/PulsarDataProducer.java
Outdated
Show resolved
Hide resolved
FelixGV
reviewed
Feb 21, 2023
FelixGV
left a comment
FelixGV
left a comment
There was a problem hiding this comment.
Was curious to learn more about Pulsar so I reviewed this. Feel free to ignore if these aren't useful comments.
...ot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/server/PulsarDataProducer.java
Outdated
Show resolved
Hide resolved
...ot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/server/PulsarDataProducer.java
Outdated
Show resolved
Hide resolved
snleee
force-pushed
the
pulsar-github-producer
branch
from
9a34980 to
c162021
Compare
snleee
force-pushed
the
pulsar-github-producer
branch
from
c162021 to
db7faf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the command to be able to publish data to Apache Pulsar cluster.