Skip to content

10249: Separating the v1beta1 & v1 ingress objects.#10367

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
abhioncbr:10249-ingress
Mar 2, 2023
Merged

10249: Separating the v1beta1 & v1 ingress objects.#10367
Jackie-Jiang merged 1 commit intoapache:masterfrom
abhioncbr:10249-ingress

Conversation

@abhioncbr
Copy link
Contributor

This PR will separate the v1beta1 & v1 ingress objects into two different files as per the bug

cc @Jackie-Jiang @xiangfu0

@abhioncbr abhioncbr changed the title 10249: Separating the v1beta1 & v1 ingress. 10249: Separating the v1beta1 & v1 ingress objects. Mar 2, 2023
@Jackie-Jiang
Copy link
Contributor

Thanks for the contribution! Will this cause backward incompatible from the file name change?

@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 March 2, 2023 18:49
@abhioncbr
Copy link
Contributor Author

Thanks for the contribution! Will this cause backward incompatible from the file name change?

Let me verify that. I'll update this ticket.

@abhioncbr
Copy link
Contributor Author

Thanks for the contribution! Will this cause backward incompatible from the file name change?

Let me verify that. I'll update this ticket.

It should be good. The name change fo the file results in change in the comment like below
# Source: pinot/templates/controller/ingress-v1beta1.yaml

@Jackie-Jiang Jackie-Jiang merged commit b6bcb05 into apache:master Mar 2, 2023
@abhioncbr abhioncbr deleted the 10249-ingress branch August 4, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants