[multistage][stats] clean up some stats#10390
Merged
walterddr merged 2 commits intoapache:masterfrom Mar 8, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10390 +/- ##
============================================
+ Coverage 70.23% 70.30% +0.06%
- Complexity 6025 6030 +5
============================================
Files 2049 2049
Lines 110869 110909 +40
Branches 16851 16860 +9
============================================
+ Hits 77873 77974 +101
+ Misses 27540 27484 -56
+ Partials 5456 5451 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9066af5 to
d6652aa
Compare
KKcorps
reviewed
Mar 8, 2023
|
|
||
| public void setStageLevelStats(@Nullable String rawTableName, BrokerResponseStats brokerResponseStats, | ||
| @Nullable BrokerMetrics brokerMetrics) { | ||
| @Nullable BrokerMetrics brokerMetrics, boolean traceEnabled) { |
Contributor
There was a problem hiding this comment.
No need to pass this flag imo. It is already part of the constructor.
KKcorps
approved these changes
Mar 8, 2023
Contributor
KKcorps
left a comment
There was a problem hiding this comment.
One minor comment, Everything else looks good.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangeList
More Details
more context and what's solved/unsolved: #10399
TODOs