10271: Updated the code for handling the slash at the end for controller.data.dir#10395
Merged
Jackie-Jiang merged 4 commits intoapache:masterfrom Mar 12, 2023
Merged
10271: Updated the code for handling the slash at the end for controller.data.dir#10395Jackie-Jiang merged 4 commits intoapache:masterfrom
Jackie-Jiang merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10395 +/- ##
=============================================
- Coverage 70.23% 32.10% -38.14%
+ Complexity 6025 273 -5752
=============================================
Files 2049 2049
Lines 110869 110869
Branches 16851 16851
=============================================
- Hits 77873 35595 -42278
- Misses 27540 72097 +44557
+ Partials 5456 3177 -2279
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Mar 12, 2023
Contributor
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR has to be tagged with at least one of the following labels (*):
bugfix