Skip to content

10271: Updated the code for handling the slash at the end for controller.data.dir#10395

Merged
Jackie-Jiang merged 4 commits intoapache:masterfrom
abhioncbr:10271-fix
Mar 12, 2023
Merged

10271: Updated the code for handling the slash at the end for controller.data.dir#10395
Jackie-Jiang merged 4 commits intoapache:masterfrom
abhioncbr:10271-fix

Conversation

@abhioncbr
Copy link
Contributor

The PR has to be tagged with at least one of the following labels (*): bugfix

  • Updated the code for handling the slash at the end for controller.data.dir.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #10395 (ef8a99e) into master (52761fc) will decrease coverage by 38.14%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #10395       +/-   ##
=============================================
- Coverage     70.23%   32.10%   -38.14%     
+ Complexity     6025      273     -5752     
=============================================
  Files          2049     2049               
  Lines        110869   110869               
  Branches      16851    16851               
=============================================
- Hits          77873    35595    -42278     
- Misses        27540    72097    +44557     
+ Partials       5456     3177     -2279     
Flag Coverage Δ
integration1 24.42% <0.00%> (-0.13%) ⬇️
integration2 ?
unittests1 ?
unittests2 13.86% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pinot/controller/ControllerConf.java 59.05% <100.00%> (-1.09%) ⬇️
...in/java/org/apache/pinot/spi/utils/BytesUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/stream/StreamMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/spi/config/table/TableType.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1274 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Jackie-Jiang Jackie-Jiang merged commit 6db6d65 into apache:master Mar 12, 2023
@abhioncbr abhioncbr deleted the 10271-fix branch August 4, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants