allow segment details page to load without indices#10398
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Mar 12, 2023
jadami10:jadami/broken-segments-ui
Merged
allow segment details page to load without indices#10398Jackie-Jiang merged 1 commit intoapache:masterfrom jadami10:jadami/broken-segments-ui
Jackie-Jiang merged 1 commit intoapache:masterfrom
jadami10:jadami/broken-segments-ui
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10398 +/- ##
============================================
- Coverage 70.23% 68.31% -1.92%
+ Complexity 6025 5265 -760
============================================
Files 2049 2049
Lines 110869 110869
Branches 16851 16851
============================================
- Hits 77873 75745 -2128
- Misses 27540 29728 +2188
+ Partials 5456 5396 -60
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Mar 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
uibugfix.calling keys on
segmentMetaData.indexeswhen that field was unavailable causes the whole page to fail. now we effectively skip the indices if they aren't available without a null error callingObject.keys