Check if serverTags as configured in tierConfigs are valid#10705
Merged
walterddr merged 4 commits intoapache:masterfrom May 2, 2023
Merged
Check if serverTags as configured in tierConfigs are valid#10705walterddr merged 4 commits intoapache:masterfrom
walterddr merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10705 +/- ##
=============================================
- Coverage 70.28% 34.88% -35.40%
+ Complexity 6430 462 -5968
=============================================
Files 2112 2112
Lines 113994 114056 +62
Branches 17219 17226 +7
=============================================
- Hits 80121 39792 -40329
- Misses 28275 70796 +42521
+ Partials 5598 3468 -2130
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1225 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
klsince
changed the title
snleee
approved these changes
May 2, 2023
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
klsince
force-pushed
the
sanity_checks_on_tier
branch
from
201d03d to
83ab7d0
Compare
walterddr
reviewed
May 2, 2023
...test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerStatelessTest.java
Show resolved
Hide resolved
walterddr
approved these changes
May 2, 2023
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
lgtm. left one questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanity check on serverTags as set in tierConfigs, to make sure they are valid