Skip to content

[multistage][cleanup] clean up opChain wake up call API#10710

Merged
walterddr merged 1 commit intoapache:masterfrom
walterddr:pr_clean_up_opchain_api
May 4, 2023
Merged

[multistage][cleanup] clean up opChain wake up call API#10710
walterddr merged 1 commit intoapache:masterfrom
walterddr:pr_clean_up_opchain_api

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented May 2, 2023

Summary

OpChainSchedulerService now accepts OpChain ID for onDataAvailable

  • decouple Mailbox concept from OpChain
  • MailboxService use callback method that accepts directly OpChainID instead of MailboxID

TODO

  • we should decouple MailboxService callback into --> mailboxID --> opChainID lookup method and onDataAvailable callback method
  • allow non-mailbox based wake up of OpChain for example local subquery result using pipeline breaker operator

@codecov-commenter
Copy link

Codecov Report

Merging #10710 (4249c61) into master (b72051c) will decrease coverage by 1.41%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master   #10710      +/-   ##
============================================
- Coverage     70.31%   68.91%   -1.41%     
- Complexity     5641     6428     +787     
============================================
  Files          2112     2112              
  Lines        114048   114047       -1     
  Branches      17223    17222       -1     
============================================
- Hits          80196    78590    -1606     
- Misses        28255    29942    +1687     
+ Partials       5597     5515      -82     
Flag Coverage Δ
integration1 ?
integration2 24.05% <0.00%> (+0.06%) ⬆️
unittests1 67.82% <85.71%> (+<0.01%) ⬆️
unittests2 13.81% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ot/query/runtime/executor/RoundRobinScheduler.java 86.58% <50.00%> (-2.58%) ⬇️
...org/apache/pinot/query/mailbox/MailboxService.java 77.14% <100.00%> (ø)
...g/apache/pinot/query/mailbox/ReceivingMailbox.java 73.80% <100.00%> (ø)
...uery/runtime/executor/OpChainSchedulerService.java 95.16% <100.00%> (ø)

... and 152 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr marked this pull request as ready for review May 3, 2023 15:04
@walterddr walterddr requested a review from xiangfu0 May 3, 2023 15:44
@walterddr walterddr merged commit b190599 into apache:master May 4, 2023
@walterddr walterddr added multi-stage Related to the multi-stage query engine cleanup labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants