[multistage] fix error propagate physical planner#11173
Merged
walterddr merged 2 commits intoapache:masterfrom Jul 28, 2023
Merged
[multistage] fix error propagate physical planner#11173walterddr merged 2 commits intoapache:masterfrom
walterddr merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2223 2225 +2
Lines 119273 119377 +104
Branches 18055 18071 +16
==========================================
Hits 137 137
- Misses 119116 119220 +104
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
commented
Jul 25, 2023
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java
Outdated
Show resolved
Hide resolved
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java
Outdated
Show resolved
Hide resolved
walterddr
force-pushed
the
pr_fix_error_propagate_physical_planner
branch
2 times, most recently
from
72b4191 to
d60f73a
Compare
add test fix test
walterddr
force-pushed
the
pr_fix_error_propagate_physical_planner
branch
2 times, most recently
from
4b756d7 to
814a9b6
Compare
walterddr
force-pushed
the
pr_fix_error_propagate_physical_planner
branch
from
814a9b6 to
ae12033
Compare
xiangfu0
approved these changes
Jul 28, 2023
s0nskar
pushed a commit
to s0nskar/pinot
that referenced
this pull request
Aug 10, 2023
* [multistage] propagate planner error back to broker * use CompletableFuture to monitor and cancel stages when error occurs. --------- Co-authored-by: Rong Rong <rongr@startree.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
TODO
QueryDispatcherside logic to unify with theQueryServerside behavior (usingSubmissionService)this fixes: #11167