ExpressionFilterOperator IS NULL and IS NOT NULL support. #11249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenyu0127
force-pushed
the
expression-filter-operator
branch
from
fe3d7f5 to
8504dc4
Compare
Codecov Report
@@ Coverage Diff @@
## master #11249 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2229 2229
Lines 119957 119983 +26
Branches 18173 18183 +10
==========================================
Hits 137 137
- Misses 119800 119826 +26
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
reviewed
Aug 2, 2023
| nullBitmap = _transformFunction.getNullBitmap(projectionBlock); | ||
| if (nullBitmap != null) { | ||
| for (int i : nullBitmap) { | ||
| matchingDocIds.add(_docIdBuffer[i]); |
| } else { | ||
| // TODO(https://github.com/apache/pinot/issues/10882): support NULL for multi-value. | ||
| if (_nullHandlingEnabled || _predicateEvaluationResult == PredicateEvaluationResult.NULL) { | ||
| throw new UnsupportedOperationException("NULL handling is not supported for multi-value"); |
Contributor
There was a problem hiding this comment.
We don't want to throw exception here. Think of a case where user needs null handling for other operators, but has a filter on MV column
Contributor
Author
There was a problem hiding this comment.
Good point.
Modified the code to not throw an exception when null handling is enabled, and to return empty matching document IDs when _predicateEvaluationResult == PredicateEvaluationResult.NULL. Also added unit tests for those two scenarios.
Jackie-Jiang
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support "WHERE func(column) IS NULL" and "WHERE func(column) IS NOT NULL".
#11209