Skip to content

Provide more detailed/consolidated exceptions#11363

Merged
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:provide-better-exceptions
Aug 17, 2023
Merged

Provide more detailed/consolidated exceptions#11363
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:provide-better-exceptions

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Aug 16, 2023

  1. Fixed the missing root cause in BlockExchange
  2. Make broker side error response more explicit

After:
image

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #11363 (7810f37) into master (4c307e1) will decrease coverage by 47.28%.
Report is 1 commits behind head on master.
The diff coverage is 16.00%.

@@              Coverage Diff              @@
##             master   #11363       +/-   ##
=============================================
- Coverage     61.52%   14.24%   -47.28%     
+ Complexity     6514      494     -6020     
=============================================
  Files          2233     2234        +1     
  Lines        120083   120106       +23     
  Branches      18223    18228        +5     
=============================================
- Hits          73880    17114    -56766     
- Misses        40801   101578    +60777     
+ Partials       5402     1414     -3988     
Flag Coverage Δ
integration1 0.00% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 14.24% <16.00%> (-47.24%) ⬇️
java-17 14.23% <16.00%> (-47.13%) ⬇️
java-20 14.24% <16.00%> (-47.14%) ⬇️
temurin 14.24% <16.00%> (-47.28%) ⬇️
unittests1 ?
unittests2 14.63% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../org/apache/pinot/common/utils/ExceptionUtils.java 0.00% <0.00%> (ø)
...a/org/apache/pinot/query/catalog/PinotCatalog.java 0.00% <0.00%> (-47.37%) ⬇️
...query/runtime/operator/exchange/BlockExchange.java 0.00% <0.00%> (ø)
...requesthandler/MultiStageBrokerRequestHandler.java 27.27% <100.00%> (+1.11%) ⬆️

... and 1394 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 force-pushed the provide-better-exceptions branch from c941ced to 7810f37 Compare August 17, 2023 01:25
@xiangfu0 xiangfu0 merged commit f82d61b into apache:master Aug 17, 2023
@xiangfu0 xiangfu0 deleted the provide-better-exceptions branch August 17, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants