Integration test exceptions fix#11396
Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom Aug 22, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11396 +/- ##
============================================
+ Coverage 61.44% 62.80% +1.35%
+ Complexity 6515 1079 -5436
============================================
Files 2234 2300 +66
Lines 120175 123622 +3447
Branches 18240 18796 +556
============================================
+ Hits 73842 77641 +3799
+ Misses 40910 40453 -457
- Partials 5423 5528 +105
Flags with carried forward coverage won't be shown. Click here to find out more. see 315 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
The context is gone. Do you still have the stack trace for the exception? It might be a real bug instead of testing issue |
Contributor
Author
yes, updated. It's currently available in any |
Jackie-Jiang
approved these changes
Aug 21, 2023
|
|
||
| protected long getCurrentCountStarResult(String tableName) { | ||
| return getPinotConnection().execute("SELECT COUNT(*) FROM " + tableName).getResultSet(0).getLong(0); | ||
| ResultSetGroup resultSetGroup = getPinotConnection().execute("SELECT COUNT(*) FROM " + tableName); |
Contributor
There was a problem hiding this comment.
(nit) wrong indentation
abhioncbr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCurrentCountStarResultto avoid theIndexOutOfBoundsException. Here is the stack trace