Skip to content

[Multi-stage] Minor fix on executor service#11416

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:clean_up_one_executor
Aug 23, 2023
Merged

[Multi-stage] Minor fix on executor service#11416
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:clean_up_one_executor

Conversation

@Jackie-Jiang
Copy link
Contributor

No description provided.

@Jackie-Jiang Jackie-Jiang added bugfix multi-stage Related to the multi-stage query engine labels Aug 23, 2023
@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 August 23, 2023 08:39
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #11416 (e0a17f8) into master (e0d0aeb) will decrease coverage by 48.39%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11416       +/-   ##
=============================================
- Coverage     62.89%   14.51%   -48.39%     
+ Complexity     1091      201      -890     
=============================================
  Files          2301     2301               
  Lines        123766   123776       +10     
  Branches      18833    18834        +1     
=============================================
- Hits          77845    17961    -59884     
- Misses        40376   104299    +63923     
+ Partials       5545     1516     -4029     
Flag Coverage Δ
integration 0.00% <0.00%> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <0.00%> (ø)
java-11 14.50% <0.00%> (-48.37%) ⬇️
java-17 14.50% <0.00%> (-0.01%) ⬇️
java-20 14.50% <0.00%> (-48.27%) ⬇️
temurin 14.51% <0.00%> (-48.39%) ⬇️
unittests 14.51% <0.00%> (-48.39%) ⬇️
unittests1 ?
unittests2 14.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...apache/pinot/query/service/server/QueryServer.java 0.00% <0.00%> (-80.00%) ⬇️
.../apache/pinot/server/worker/WorkerQueryServer.java 0.00% <ø> (ø)

... and 1476 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, how many more ExecutorService to kill?

@Jackie-Jiang
Copy link
Contributor Author

Jackie-Jiang commented Aug 23, 2023

nice, how many more ExecutorService to kill?

Currently we have 4 executor services multi-stage query handling:

  • Two on broker
    • One for control flow (dispatch query plan)
    • One for data flow (will probably clean it up since it is used in a blocking way)
  • Two on server
    • One for control flow (submit to executor)
    • One for data flow (execution)

@Jackie-Jiang Jackie-Jiang merged commit e6efb9c into apache:master Aug 23, 2023
@Jackie-Jiang Jackie-Jiang deleted the clean_up_one_executor branch August 23, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants