Skip computation incase of Null Literal for case/when transformation#11444
Conversation
…en transformation.
Codecov Report
@@ Coverage Diff @@
## master #11444 +/- ##
============================================
+ Coverage 62.99% 63.02% +0.02%
+ Complexity 1107 1095 -12
============================================
Files 2303 2302 -1
Lines 124041 124032 -9
Branches 18895 18901 +6
============================================
+ Hits 78137 78168 +31
+ Misses 40352 40320 -32
+ Partials 5552 5544 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
Show resolved
Hide resolved
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
Show resolved
Hide resolved
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
Outdated
Show resolved
Hide resolved
shenyu0127
left a comment
There was a problem hiding this comment.
If would be good to add a test to CaseTransformFunctionTest which uses a query "SELECT CASE WHEN xx THEN xx ELSE NULL" and assert the query results to exercise the modified code paths.
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java
Outdated
Show resolved
Hide resolved
Did you add a test? The rest looks good to me. |
As per the discussion of the PR
cc @shenyu0127 @Jackie-Jiang