Use getResponseBodyAsStream instead of getResponseBody#11465
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Aug 31, 2023
Merged
Use getResponseBodyAsStream instead of getResponseBody#11465xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0 merged 1 commit intoapache:masterfrom
Conversation
…verted into JSON. Changing that to directly populate JSON using the Stream to reduce the memory overhead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11465 +/- ##
============================================
+ Coverage 62.92% 62.96% +0.04%
- Complexity 1108 1110 +2
============================================
Files 2318 2318
Lines 124328 124321 -7
Branches 18980 18980
============================================
+ Hits 78234 78280 +46
+ Misses 40539 40482 -57
- Partials 5555 5559 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
approved these changes
Aug 31, 2023
KKcorps
pushed a commit
to KKcorps/incubator-pinot
that referenced
this pull request
Sep 5, 2023
…verted into JSON. Changing that to directly populate JSON using the Stream to reduce the memory overhead. (apache#11465)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running a large test, below log is seen often.
2023/08/25 03:33:51.864 WARN [HttpMethodBase] [pool-12-thread-5] Going to buffer response body of large or unknown size. Using getResponseBodyAsStream instead is recommended.
This is coming from Apache library when the buffered response size is larger than http.method.response.buffer.warnlimit.
This PR replaces few usages of getResponseBody with getResponseBodyAsStream