Make all accessor methods on BrokerResponse public #11506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In apache#10932, I requested for BrokerResponse class to be made public so that an external implementation of PinotClientTransport could be created. At that time, I failed to rectify that most of the methods to access data from BrokerResponse class are package-private which again hinders using them in a custom transport. Hence, opening this PR to make those public methods too. CC: @tsegismont
Codecov Report
@@ Coverage Diff @@
## master #11506 +/- ##
============================================
- Coverage 63.06% 63.02% -0.05%
- Complexity 1106 1108 +2
============================================
Files 2320 2320
Lines 124520 124520
Branches 19011 19011
============================================
- Hits 78528 78474 -54
- Misses 40396 40453 +57
+ Partials 5596 5593 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
added
release-notes
xiangfu0
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix, release-notes, pinot-java-client
In #10932, I requested for BrokerResponse class to be made public so that an external implementation of PinotClientTransport could be created. At that time, I failed to rectify that most of the methods to access data from BrokerResponse class are package-private which again hinders using them in a custom transport. Hence, opening this PR to make those public methods too.
CC: @tsegismont