Add metric to track the number of primary keys in valid doc id snapshot#11515
Merged
xiangfu0 merged 2 commits intoapache:masterfrom Sep 6, 2023
Merged
Add metric to track the number of primary keys in valid doc id snapshot#11515xiangfu0 merged 2 commits intoapache:masterfrom
xiangfu0 merged 2 commits intoapache:masterfrom
Conversation
saurabhd336
approved these changes
Sep 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #11515 +/- ##
============================================
+ Coverage 62.99% 63.07% +0.08%
- Complexity 1094 1108 +14
============================================
Files 2302 2320 +18
Lines 124025 124528 +503
Branches 18901 19010 +109
============================================
+ Hits 78126 78548 +422
- Misses 40351 40373 +22
- Partials 5548 5607 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 159 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help to detect any large inconsistencies b/w the number of primary keys in server vs the keys in snapshot.
The old PR got messy after rebase so raising a new one