[WIP] Use lombok to simplify code#11756
Conversation
zhtaoxiang
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11756 +/- ##
============================================
- Coverage 63.13% 63.07% -0.07%
- Complexity 1117 1118 +1
============================================
Files 2342 2342
Lines 125916 125807 -109
Branches 19370 19370
============================================
- Hits 79501 79355 -146
- Misses 40749 40798 +49
+ Partials 5666 5654 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
added
cleanup
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Suggest adding it for POJO classes first. I feel it is less readable for regular classes
| * pinot.broker.access.control.principals.user456.tables=stuff,lessImportantStuff | ||
| * </pre> | ||
| */ | ||
| @NoArgsConstructor |
There was a problem hiding this comment.
I don't think this is needed because there is no other constructor. Same for other classes with single empty constructor
There was a problem hiding this comment.
make sense. will clean up
make sense |
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Mostly good. Please go over the classes again to fix the similar issues as the comments pointed out
| throws SQLException { | ||
| _maxRows = rows; | ||
| } | ||
|
|
| @AllArgsConstructor | ||
| public class QueryQuotaEntity { | ||
|
|
||
| @Getter |
There was a problem hiding this comment.
No need to keep exact match. For POJO, we can annotate the class
| return _tablePartitionInfo; | ||
| } | ||
|
|
||
| @AllArgsConstructor(access = AccessLevel.PACKAGE) |
There was a problem hiding this comment.
(minor) For private sub-class, no need to put access level
| * Connections time out for AsyncHttpClient | ||
| */ | ||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| @Getter |
There was a problem hiding this comment.
(minor) not introduced in this PR, but let's reformat this file to fix the indentation
| * <p>Please note that objects of this class will hold a reference to the given JsonNode object | ||
| * and that will only be released when the object is GC'ed.</p> | ||
| */ | ||
| @AllArgsConstructor(access = AccessLevel.PACKAGE) |
There was a problem hiding this comment.
Let's change it to public access
| _preferTlsPort = preferTlsPort; | ||
| _zkClient = zkClient; | ||
| } | ||
| public ExternalViewReader(ZkClient zkClient) { |
3 participants
label:
refactorUse lombok in al pinot modules:
@getter@setter@NoArgsConstructorand@AllArgsConstructorThere is no logic change.
Done modules: