11743: remove placeholder OBJECT column data type.#11816
11743: remove placeholder OBJECT column data type.#11816abhioncbr wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11816 +/- ##
=============================================
- Coverage 63.14% 14.40% -48.75%
+ Complexity 1140 201 -939
=============================================
Files 2343 2343
Lines 126420 126428 +8
Branches 19442 19442
=============================================
- Hits 79832 18212 -61620
- Misses 40914 106669 +65755
+ Partials 5674 1547 -4127
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1511 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| put(float[].class, ColumnDataType.FLOAT_ARRAY); | ||
| put(double[].class, ColumnDataType.DOUBLE_ARRAY); | ||
| put(String[].class, ColumnDataType.STRING_ARRAY); | ||
| put(Object.class, ColumnDataType.OBJECT); |
There was a problem hiding this comment.
Removing this leads it to return null; hence, we set the _resultMetadata in ScalarTransformationFunction or in PostAggregationFunction as String. Eventually, it fails while evaluating the valueblock.
@Jackie-Jiang / @walterddr do you guys think determining the _resultMetadata based on the transformation function result makes sense like we are doing in CaseTransformFunction
2 participants
As per the issue, deleting the placeholder OBJECT data type.