Skip to content

add theta sketch - string conversion#12256

Closed
walterddr wants to merge 1 commit intoapache:masterfrom
walterddr:add_theta_sketch_conversion
Closed

add theta sketch - string conversion#12256
walterddr wants to merge 1 commit intoapache:masterfrom
walterddr:add_theta_sketch_conversion

Conversation

@walterddr
Copy link
Contributor

No description provided.

@walterddr walterddr force-pushed the add_theta_sketch_conversion branch from 7a3a19f to e5dd98f Compare January 11, 2024 03:03
Copy link
Member

@kishoreg kishoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add description
  • simple test case before merging

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d05e3bd) 61.38% compared to head (e5dd98f) 61.58%.
Report is 4 commits behind head on master.

Files Patch % Lines
...he/pinot/core/function/scalar/SketchFunctions.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12256      +/-   ##
============================================
+ Coverage     61.38%   61.58%   +0.20%     
  Complexity     1152     1152              
============================================
  Files          2416     2416              
  Lines        131198   131206       +8     
  Branches      20249    20250       +1     
============================================
+ Hits          80531    80799     +268     
+ Misses        44767    44511     -256     
+ Partials       5900     5896       -4     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.53% <0.00%> (+33.84%) ⬆️
java-21 61.44% <0.00%> (+26.76%) ⬆️
skip-bytebuffers-false 61.56% <0.00%> (+0.19%) ⬆️
skip-bytebuffers-true 61.41% <0.00%> (+26.74%) ⬆️
temurin 61.58% <0.00%> (+0.20%) ⬆️
unittests 61.57% <0.00%> (+0.20%) ⬆️
unittests1 46.62% <0.00%> (+0.19%) ⬆️
unittests2 27.74% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walterddr
Copy link
Contributor Author

closing this one as there's already fromBase64 scalarfunction. until we have a different way to encode sketch we will not have needs for this method.

@walterddr walterddr closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants