remove akka from LICENSE-binary#12443
Merged
xiangfu0 merged 2 commits intoapache:masterfrom Feb 20, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12443 +/- ##
============================================
- Coverage 61.77% 61.74% -0.04%
Complexity 207 207
============================================
Files 2436 2436
Lines 133130 133130
Branches 20623 20623
============================================
- Hits 82241 82196 -45
- Misses 44850 44887 +37
- Partials 6039 6047 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
reviewed
Feb 19, 2024
| com.typesafe.akka:akka-slf4j_2.12:2.5.21 | ||
| com.typesafe.akka:akka-stream_2.12:2.5.21 | ||
| com.typesafe.netty:netty-reactive-streams:2.0.6 | ||
| com.typesafe.scala-logging:scala-logging_2.12:3.9.2 |
Contributor
There was a problem hiding this comment.
I think this is still in use:
mvn dependency:tree |grep typesafe
[INFO] | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | +- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:compile
[INFO] | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.6:compile
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
[INFO] | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
[INFO] | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
[INFO] | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:test
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:test
[INFO] | | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
add back scala-logging
xiangfu0
approved these changes
Feb 20, 2024
Contributor
|
Thanks for updating this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I downloaded the Pinot 1.0.0 binary release and couldn't find any Akka jars or classes. Since Akka is no longer OSS, it is good to try to remove remaining uses.